-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update-balena-supervisor: add network-online dependency #3492
Draft
rcooke-warwick
wants to merge
1
commit into
master
Choose a base branch
from
ryan/update-supervisor-network-target
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcooke-warwick
temporarily deployed
to
balena-cloud.com
August 14, 2024 15:07 — with
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
August 14, 2024 15:07 — with
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
August 14, 2024 15:07 — with
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
August 14, 2024 15:07 — with
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
August 14, 2024 15:07 — with
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
August 14, 2024 15:07 — with
GitHub Actions
Inactive
Website deployed to CF Pages, 👀 preview link https://ba238015.balena-os.pages.dev |
rcooke-warwick
temporarily deployed
to
balena-cloud.com
August 14, 2024 15:59 — with
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
August 14, 2024 15:59 — with
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
August 14, 2024 15:59 — with
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
August 14, 2024 16:17 — with
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
August 14, 2024 16:17 — with
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
August 14, 2024 16:17 — with
GitHub Actions
Inactive
There is a race condition present when purging a device and rebooting. If "update-balena-supervisor" comes up before the device can connect to the internet, it will fail to pull the supervisor image. As this service stops "balena-supervisor.service" , this isn't attempted again for at least 15 min = (up to 1 hour) when the "update-balena-supervisor.timer" triggers it. Change-type: patch Signed-off-by: Ryan Cooke <[email protected]>
rcooke-warwick
force-pushed
the
ryan/update-supervisor-network-target
branch
from
August 15, 2024 09:53
b81f70a
to
562f963
Compare
rcooke-warwick
temporarily deployed
to
balena-cloud.com
August 15, 2024 09:53 — with
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
August 15, 2024 09:53 — with
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
August 15, 2024 09:53 — with
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
August 15, 2024 09:53 — with
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
August 15, 2024 09:53 — with
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
August 15, 2024 09:53 — with
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
August 15, 2024 10:43 — with
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
August 15, 2024 10:43 — with
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
August 15, 2024 10:43 — with
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
August 15, 2024 10:58 — with
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
August 15, 2024 10:58 — with
GitHub Actions
Inactive
rcooke-warwick
temporarily deployed
to
balena-cloud.com
August 15, 2024 10:58 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race condition present when purging a device and rebooting. If "update-balena-supervisor" comes up before the device can connect to the internet, it will fail to pull the supervisor image. As this service stops "balena-supervisor.service" , this isn't attempted again for at least 15 min = (up to 1 hour) when the "update-balena-supervisor.timer" triggers it.
Change-type: patch
Currently left in draft, in order to get a build to test with on a device
Contributor checklist
Change-type
present on at least one commitSigned-off-by
is presentReviewer Guidelines